ci: add no-console ESLint rule to catch accidental console.log in production (Closes #945) - #1039
Open
waterWang wants to merge 1 commit into
Open
ci: add no-console ESLint rule to catch accidental console.log in production (Closes #945)#1039waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…duction Adds the ESLint 'no-console' rule at 'warn' level, allowing console.warn and console.error for intentional logging. Closes CredenceOrg#945
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ESLint
no-consolerule atwarnlevel to prevent accidentalconsole.logstatements from reaching production bundles.Changes
no-console: ['warn', { allow: ['warn', 'error'] }]ruleconsole.warnandconsole.errorare intentionally allowed for legitimate diagnostic logging.Closes #945